New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Support for Clang and new Qt Version: 5.15 (on Mac) #549
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #549 +/- ##
========================================
Coverage 48.77% 48.77%
========================================
Files 129 129
Lines 10036 10036
========================================
Hits 4895 4895
Misses 5141 5141
Continue to review full report at Codecov.
|
I'm not sure I understand the codecov/patch failure... |
@jonoomph The explanation is shown in the detail view, though it still takes a bit of unpacking. Specifically, at this point in the diff: Codecov flags an "added" (really edited, but they count it as added) line of code as not being covered by tests. That line is the only line of program source in the entire PR (all the rest are One of Codecov's criteria is what percentage of the diff adds lines that have unit test coverage. I think the default settings expect at least 50% coverage for code in the diff. (Obviously with only one qualifying line, the only real possibilities are 100% or 0%.) |
Adding Qt 5.15 support for Mac builds, and misc fixes to allow clang++ and clang to correctly build libopenshot. This bumps the minimum Mac OS X version to 10.13 (due to our pre-compiled Qt library). In the future, we can compile that ourselves, and drop the minimum back to 10.9 (if there is a demand for it).
Also, changes GitLab builder to new Linux builder,
Related to PRs:
OpenShot/libopenshot-audio#100
OpenShot/openshot-qt#3604