Drop QtMultimedia and QtMultimediaWidgets deps #551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out, we don't actually use any of the classes in QtMultimedia (or its Widgets), so this PR drops them as dependencies.
This also prevents both Qt5Network and Qt5OpenGL getting pulled in as dependencies, and reduces our Qt dependency fingerprint significantly to just the three modules (now) listed in the
CMakeLists.txt
: QtCore, QtGui, and QtWidgets.Shared libs being what they are, it only reduces the final size of
libopenshot.so
by about 33Kb, but the size isn't the point. (Besides, not loading four big Qt modules could give runtime a teeny tiny bit more pep, theoretically.)