Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Qt::endl with QTextStream #555

Merged
merged 3 commits into from Sep 10, 2020
Merged

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Aug 20, 2020

Recent Qt releases complain about endl being used to terminate QTextStream lines, and recommend using Qt::endl instead. So, let's.

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #555 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #555   +/-   ##
========================================
  Coverage    48.77%   48.77%           
========================================
  Files          129      129           
  Lines        10036    10036           
========================================
  Hits          4895     4895           
  Misses        5141     5141           
Impacted Files Coverage Δ
src/CacheDisk.cpp 71.69% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d121f9d...92293d3. Read the comment docs.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Aug 20, 2020

Well, turns out Qt::endl wasn't a thing before Qt 5.14.0, so long story short, now we have a QtUtilities.h to go with our other compatibility headers. 😛

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Sep 10, 2020

This is incredibly minor, since it only impacts one source file (the only place we use QTextStream for output). We should perhaps be more consistent and use it in more places, but for now it's only CacheDisk. Point is, it passes Travis and should be fine. Merging.

@ferdnyc ferdnyc merged commit 22f8968 into OpenShot:develop Sep 10, 2020
@ferdnyc ferdnyc deleted the fix-deprecated-endl branch September 10, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant