Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::make_shared to allocate shared ptrs, instead of std::shared_ptr constructors #556

Merged
merged 7 commits into from
Oct 16, 2020
Merged

Use std::make_shared to allocate shared ptrs, instead of std::shared_ptr constructors #556

merged 7 commits into from
Oct 16, 2020

Commits on Aug 20, 2020

  1. Use std::make_shared to allocate shared ptrs 

    std::make_shared does in a single allocation what the constructors
for std::shared_ptr usually take at least 2 allocations to do.
May give us an infinitesimal performance/memory improvement.

https://www.modernescpp.com/index.php/memory-and-performance-overhead-of-smart-pointer
    @ferdnyc
    ferdnyc committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    3c2532b View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. Frame.cpp/h: Fix a bunch of wrong comments 

    Best reason not to narrate the code in the comments: The code gets
changed, but the documentation doesn't.
    @ferdnyc
    ferdnyc committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    c14922d View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2020

  1. Frame: Put Qt includes where they're used

    @ferdnyc
    ferdnyc committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    1c8aea9 View commit details
    Browse the repository at this point in the history

  2. Frame: Use delegating constructors

    @ferdnyc
    ferdnyc committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    9c83429 View commit details
    Browse the repository at this point in the history

  3. Pixelate: Fix missing includes

    @ferdnyc
    ferdnyc committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    0974637 View commit details
    Browse the repository at this point in the history

  4. VideoRenderWidget: missing includes

    @ferdnyc
    ferdnyc committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    92d33a1 View commit details
    Browse the repository at this point in the history

  5. Frame: Reduce code duplication

    @ferdnyc
    ferdnyc committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    0bcf1e4 View commit details
    Browse the repository at this point in the history