Tests: Don't enable HW accel as side-effect #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Settings test attempts to test the class by changing settings variables and reading them back again. Problem is, that affects the REST of the unit tests. So instead of enabling HW accel and causing crashes, we'll diddle something innocuous, like OMP_THREADS.
|
This is actively preventing libopenshot from being packaged for Fedora 33, so I'm planning to merge this ASAP so I can apply the commit to our 0.2.5 build tree. |
Codecov Report
@@ Coverage Diff @@
## develop #557 +/- ##
===========================================
- Coverage 48.77% 48.69% -0.08%
===========================================
Files 129 129
Lines 10036 10036
===========================================
- Hits 4895 4887 -8
- Misses 5141 5149 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Settings test attempts to test the class by changing settings variables and reading them back again. Problem is, that affects the REST of the unit tests.
So instead of changing
HARDWARE_ACCEL(accidentally enabling HW accel and causing test failures), we'll diddle something more innocuous, likeOMP_THREADS.