FrameMapper + Resampling loses samples #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sample. Apparently, we need enough padding, so we exceed the # of samples required for the first frame, and 20 was just too low for many frame rates / sample rates.
Codecov Report
@@ Coverage Diff @@
## develop #568 +/- ##
===========================================
+ Coverage 49.37% 49.39% +0.01%
===========================================
Files 129 129
Lines 10198 10198
===========================================
+ Hits 5035 5037 +2
+ Misses 5163 5161 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, we need enough padding during resampling, so we exceed the # of samples required for the first frame, and 20 was just too low for many frame rates / sample rates. This seems kind of random / arbitrary, but it's an easy fix for a more complex issue, where resampling always leaves behind some samples for the next call, and we can really mess up our sample division logic.