Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENABLE_MAGICK CMake option (default ON) #574

Merged
merged 2 commits into from Oct 4, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Oct 4, 2020

This will allow building with ImageMagick support to be switched off (using -DENABLE_MAGICK=0 on the cmake command line), even if it's detected on the system (which was previously not possible).

Also: Change the default build type (when not specified at all) from Debug to Release, which is more typically what's expected.

@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #574 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #574   +/-   ##
========================================
  Coverage    49.39%   49.39%           
========================================
  Files          129      129           
  Lines        10198    10198           
========================================
  Hits          5037     5037           
  Misses        5161     5161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e98fb7...172c3c0. Read the comment docs.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Oct 4, 2020

I'm going to merge this immediately since it's fairly trivial, and I'm hoping it might help solve some issues seen in #573 .

@ferdnyc ferdnyc merged commit 414a2cd into OpenShot:develop Oct 4, 2020
@ferdnyc ferdnyc deleted the imagemagick-option branch October 4, 2020 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant