New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various unit tests: Increase coverage #586
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #586 +/- ##
===========================================
+ Coverage 49.90% 52.28% +2.37%
===========================================
Files 132 131 -1
Lines 10686 10761 +75
===========================================
+ Hits 5333 5626 +293
+ Misses 5353 5135 -218
Continue to review full report at Codecov.
|
LGTM! |
Merge when ready! |
- Add tests for second constructor, JSON in/out
- Add blank constructor, JSON in/out tests More Point tests
8d3e87d
to
db738ce
Compare
I think I've run out of steam on this one for now. Just made a change to |
(My attempt to exclude The two files that get built into targets by CMake still show up in the list, but Codecov doesn't seem to be counting any of their source lines for coverage purposes, which I guess is what really matters. Was hoping to get them off the list entirely, but meh... |
Update: I'm an idiot. The failure was due to the short duration, and the fact that there were only 120 frames available in the reader at the specified frame rate. (Though, interestingly, that doesn't throw an
OutOfBoundsFrame
it seems.)As it says, this PR is a work-in-progress. Not because it's unfinished, but because a test is failing.I decided to replace the first test (which had a
catch
in it that was screwing up the test coverage) with a simple no-op test: Create a mapping from 24fps to 24fps with no pulldown. Then read itsName()
(adds an extra line of coverage), and finally read one frame from it. So, it just gets the same frame back. (When you use the right duration.)Unfortunately, the test fails, and gets back frame120
for original frame125
.That seems bad.
Edit: Added a JSON test that just reads the
Json()
string from the mapper, thenSetJson()
s it back again (and spot-checks that things haven't changed.) That really raised the test coverage; I may do that for the other classes as well.