Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov.yml: Update ignore list #587

Merged
merged 1 commit into from Nov 5, 2020
Merged

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Nov 5, 2020

I realized we were trying too hard. According to the expansion returned by their validator,

ignore:
  - "examples/**/*"
  - "bindings/**/*"

translates to:

{
  "ignore": [
    "(?s:examples/.*/[^\\/]+)\\Z",
    "(?s:bindings/.*/[^\\/]+)\\Z"
]}

Which will ignore all files two levels below examples and bindings, but won't ignore any files directly inside either dir.

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #587 into develop will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #587      +/-   ##
===========================================
+ Coverage    52.28%   52.54%   +0.26%     
===========================================
  Files          131      129       -2     
  Lines        10761    10707      -54     
===========================================
  Hits          5626     5626              
+ Misses        5135     5081      -54     
Impacted Files Coverage Δ
examples/ExampleHtml.cpp
examples/Example.cpp

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb87cc7...37bcff9. Read the comment docs.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Nov 5, 2020

There we go, that's got it. Merging.

@ferdnyc ferdnyc merged commit b910d2f into OpenShot:develop Nov 5, 2020
@ferdnyc ferdnyc deleted the codecov-ignore branch November 5, 2020 22:10
@jonoomph
Copy link
Member

jonoomph commented Nov 5, 2020

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants