Unit tests: Don't use OpenShot.h header #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- To prevent slow compiles of unit tests, replace all of the '#include "OpenShot.h"' invocations with includes of the individual headers actually needed by each test file.
Codecov Report
@@ Coverage Diff @@
## develop #607 +/- ##
========================================
Coverage 52.31% 52.31%
========================================
Files 129 129
Lines 10783 10783
========================================
Hits 5641 5641
Misses 5142 5142
Continue to review full report at Codecov.
|
|
I'm going to merge this one... #585 might've inspired it, but it's useful even without OpenCV in the mix. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent slow compiles of unit tests, this PR replaces all of the
#include "OpenShot.h"invocations with includes of the individual headers actually needed by each test file. This has little effect on files likeClip_Tests.cppandFrame_Tests.cpp, but hugely speeds up the compilation (and reduces the size) of files likeCoordinate_Tests.cppandFraction_Tests.cpp.