Revert cache-busting-on-seek Experiment #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…failed experiement, not to mention that it destroys performance on the "Transform" tool.
Codecov Report
@@ Coverage Diff @@
## develop #610 +/- ##
===========================================
+ Coverage 52.31% 52.74% +0.43%
===========================================
Files 129 129
Lines 10783 11073 +290
===========================================
+ Hits 5641 5841 +200
- Misses 5142 5232 +90
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting 'clear the cache when the user seeks' experiment. It was a failed experiment, not to mention that it destroys performance on the "Transform" tool. In theory, I was worried about boundaries between seek blocks. But I think having some inconsistent moments between blocks of separately decoded frames is okay during a real-time preview scenario. When final render is happening, we don't seek randomly around, and so this is not a problem.