Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanks to @ferdnyc for the suggestion to better detect alpha channels. #620

Merged
merged 1 commit into from Jan 27, 2021

Conversation

jonoomph
Copy link
Member

Related to #609. Implementing a much improved alpha channel detection method, which works on all formats that contain an alpha channel. Shout out to @ferdnyc for the suggestion!

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #620 (d6ec5da) into develop (5cc0455) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #620      +/-   ##
===========================================
- Coverage    52.32%   52.25%   -0.08%     
===========================================
  Files          129      129              
  Lines        10791    10773      -18     
===========================================
- Hits          5646     5629      -17     
+ Misses        5145     5144       -1     
Impacted Files Coverage Δ
src/FFmpegUtilities.h 100.00% <100.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc0455...d6ec5da. Read the comment docs.

@jonoomph jonoomph merged commit 1e03d2c into develop Jan 27, 2021
@jonoomph jonoomph deleted the fix-alpha-frank-rocks branch January 27, 2021 03:46
@jonoomph
Copy link
Member Author

Sorry to disappoint, lol. I'm not opposed to dropping older FFmpeg support though. As long as we support the past 4 or 5+ years of FFmpeg (which I think is around FFmpeg 3.4), that seems very reasonable.

@ferdnyc
Copy link
Contributor

ferdnyc commented Jan 27, 2021

@jonoomph
Well, Ubuntu 16.04 shipped with FFmpeg 2.8, and won't technically be EOL'd until April of this year. (It also still uses Python 3.5, which has been EOL'd for nearly a year already, so that's confusing.)

Come April, though, there's really no reason to support anything pre-3.4, as that's what was included in Ubuntu 18.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants