Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effect GetFrame(): Use std::make_shared #621

Merged
merged 2 commits into from Jan 28, 2021

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Jan 27, 2021

This PR tweaks the GetFrame(int64_t frame_number) overload in each effect from:

std::shared_ptr<openshot::Frame> GetFrame(int64_t frame_number) override {
    return GetFrame(std::shared_ptr<Frame> (new Frame()), frame_number);
}

to:

std::shared_ptr<openshot::Frame> GetFrame(int64_t frame_number) override {
    return GetFrame(std::make_shared<openshot::Frame>(), frame_number);
}

In accordance with #556, which did the same for other instances of shared-pointer creation. Extended rationale there.

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #621 (57678ac) into develop (3b73425) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #621   +/-   ##
========================================
  Coverage    52.54%   52.54%           
========================================
  Files          129      129           
  Lines        10827    10827           
========================================
  Hits          5689     5689           
  Misses        5138     5138           
Impacted Files Coverage Δ
src/effects/Bars.h 0.00% <0.00%> (ø)
src/effects/Blur.h 50.00% <0.00%> (ø)
src/effects/Brightness.h 0.00% <0.00%> (ø)
src/effects/Caption.h 0.00% <0.00%> (ø)
src/effects/ChromaKey.h 0.00% <0.00%> (ø)
src/effects/ColorShift.h 0.00% <0.00%> (ø)
src/effects/Crop.h 0.00% <0.00%> (ø)
src/effects/Deinterlace.h 0.00% <0.00%> (ø)
src/effects/Hue.h 0.00% <0.00%> (ø)
src/effects/Mask.h 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b73425...c98b041. Read the comment docs.

@jonoomph
Copy link
Member

LGTM!

@github-actions
Copy link

Merge conflicts have been detected on this PR, please resolve.

@github-actions github-actions bot added the conflicts A PR with unresolved merge conflicts label Jan 27, 2021
@ferdnyc ferdnyc removed the conflicts A PR with unresolved merge conflicts label Jan 27, 2021
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Jan 28, 2021

Conflicts resolved, merging.

@ferdnyc ferdnyc merged commit cb816e1 into OpenShot:develop Jan 28, 2021
@ferdnyc ferdnyc deleted the effect-make-shared branch January 28, 2021 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants