Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Protobuf and OpenCV to CI preinstalls #626

Merged
merged 1 commit into from Jan 29, 2021

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Jan 29, 2021

Make sure our CI runs are built with OpenCV and Protocol Buffers enabled.

@ferdnyc ferdnyc added build Issues related to compiling or installing libopenshot and its dependencies dependencies Pull requests that update a dependency file labels Jan 29, 2021
@ferdnyc ferdnyc force-pushed the ci-for-opencv branch 2 times, most recently from 5bba726 to df185c5 Compare January 29, 2021 01:51
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #626 (af98221) into develop (47afa20) will decrease coverage by 0.90%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #626      +/-   ##
===========================================
- Coverage    52.79%   51.89%   -0.91%     
===========================================
  Files          130      151      +21     
  Lines        10882    12341    +1459     
===========================================
+ Hits          5745     6404     +659     
- Misses        5137     5937     +800     
Impacted Files Coverage Δ
src/effects/ObjectDetection.cpp 0.00% <ø> (ø)
src/effects/Stabilizer.cpp 0.00% <ø> (ø)
src/effects/Tracker.cpp 0.00% <ø> (ø)
src/EffectInfo.cpp 0.00% <0.00%> (ø)
tests/Frame_Tests.cpp 100.00% <0.00%> (ø)
src/sort_filter/KalmanTracker.h 100.00% <0.00%> (ø)
src/CVObjectDetection.h 0.00% <0.00%> (ø)
tests/CVTracker_Tests.cpp 100.00% <0.00%> (ø)
src/ProcessingController.h 40.54% <0.00%> (ø)
src/CVTracker.h 81.81% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47afa20...8f0e1fe. Read the comment docs.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Jan 29, 2021

From an apt perspective, the added installs are:

sudo apt install libopencv-dev libprotobuf-dev protobuf-compiler

(Leave out that last one, you'll get very strange errors because instead of being replaced with the path to the protoc executable, the protobuf::protoc target ends up in the Makefile as a dependency. Which breaks it completely, :: not being valid unescaped path characters in Make.)

Installing individual OpenCV library components (e.g. libopencv-core-dev, etc. is a nice idea, to avoid installation bloat, and that's how I started. But none of them install the CMake configs needed to properly configure the targets. Those are only in libopencv-dev itself. So it'll just have to install everything.

@ferdnyc ferdnyc merged commit f1102a2 into OpenShot:develop Jan 29, 2021
@ferdnyc ferdnyc deleted the ci-for-opencv branch January 29, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to compiling or installing libopenshot and its dependencies dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant