Tweak the Python bindings for KeyFrame, Fraction #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python code expects __str__() on a Fraction to return a
"{num}:{den}" representation, which __repr__() no longer does.
Codecov Report
@@ Coverage Diff @@
## develop #628 +/- ##
===========================================
- Coverage 51.89% 51.85% -0.04%
===========================================
Files 151 151
Lines 12341 12332 -9
===========================================
- Hits 6404 6395 -9
Misses 5937 5937
Continue to review full report at Codecov.
|
|
Excellent: This worked to fix Ubuntu 16.04. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I screwed up the slot name for Fraction's string representation (
__str__not__string__, dummy!), so this PR fixes that.It also gets rid of the
Keyframe(std::vector<Coordinate>)constructor, which as SWIG points out in an emitted warning will shadowKeyframe(std::vector<Point>)or vice versa, and thePointversion is far more useful. The aliased names for the arguments are also removed, on the off chance they're part of what's messing up SWIG on Ubuntu 16.04.