FFmpegReader: Throw correct exception #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only reason an `AV_ALLOCATE_FRAME()` could fail is because there wasn't enough memory to allocate the necessary buffers, so if it returns a `nullptr` then throwing `OutOfMemory` makes far more sense than throwing `OutOfBoundsFrame`.
Codecov Report
@@ Coverage Diff @@
## develop #647 +/- ##
========================================
Coverage 51.53% 51.53%
========================================
Files 151 151
Lines 12231 12231
========================================
Hits 6303 6303
Misses 5928 5928
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only reason an
AV_ALLOCATE_FRAME()could fail is becausethere wasn't enough memory to allocate the necessary buffers,
so if it returns a
nullptrthen throwingOutOfMemorymakesfar more sense than throwing
OutOfBoundsFrame.Related to #644 (comment)