Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Make ImageWriter tests dependent on ImageMagick being enabled #659

Merged
merged 1 commit into from Apr 19, 2021

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Apr 19, 2021

Just like the OpenCV tests require OpenCV, the ImageWriter tests require that ImageMagick be enabled in the build. If it isn't, skip those tests entirely. Silences a CTest message correctly complaining that the unit test executable "has no tests!", when not linked with ImageMagick.

Just like the OpenCV tests require OpenCV, the ImageWriter tests
require that ImageMagick be enabled in the build. If it isn't,
skip those tests.
@ferdnyc ferdnyc added build Issues related to compiling or installing libopenshot and its dependencies tests Changes related to the unit tests and/or code coverage labels Apr 19, 2021
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #659 (deb0ebe) into develop (7a6ff7c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #659   +/-   ##
========================================
  Coverage    52.42%   52.42%           
========================================
  Files          151      151           
  Lines        12346    12346           
========================================
  Hits          6473     6473           
  Misses        5873     5873           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a6ff7c...deb0ebe. Read the comment docs.

@ferdnyc ferdnyc merged commit 51dde66 into OpenShot:develop Apr 19, 2021
@ferdnyc ferdnyc deleted the optional-imagereader-tests branch April 19, 2021 19:26
@ferdnyc ferdnyc restored the optional-imagereader-tests branch June 6, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to compiling or installing libopenshot and its dependencies tests Changes related to the unit tests and/or code coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant