Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade OpenCV 4.5.1 msg to WARNING #664

Merged

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Apr 24, 2021

I misread the CMake docs, and didn't realize that SEND_ERROR message severity would still register as a failed config at the end of the run. So, OpenCV 4.5.1 is still killing our Ubuntu Impish PPA builds.

Downgrade to WARNING to let them succeed.

@ferdnyc ferdnyc added the build Issues related to compiling or installing libopenshot and its dependencies label Apr 24, 2021
@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #664 (3a4f2ae) into develop (acda566) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #664   +/-   ##
========================================
  Coverage    52.42%   52.42%           
========================================
  Files          151      151           
  Lines        12346    12346           
========================================
  Hits          6473     6473           
  Misses        5873     5873           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acda566...3a4f2ae. Read the comment docs.

@ferdnyc ferdnyc merged commit a00bbb7 into OpenShot:develop Apr 24, 2021
@ferdnyc ferdnyc deleted the defense-against-the-dark-opencv451 branch April 24, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to compiling or installing libopenshot and its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant