Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Support LIBOPENSHOT_DEBUG envvar #667

Merged
merged 3 commits into from May 15, 2021

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Apr 27, 2021

This was originally part of my PR #593, but that was too ambitious and is stuck on hold for the moment. So, I broke this useful feature out into its own PR. With this change, setting LIBOPENSHOT_DEBUG to any value in the process environment directs the ZeroMQ debug logging stream to stderr (in addition to any other file/subscriber destinations).

- Setting LIBOPENSHOT_DEBUG to any value in the process environment
  activates debug logging to stderr.
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #667 (97c2530) into develop (a00bbb7) will decrease coverage by 0.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #667      +/-   ##
===========================================
- Coverage    52.42%   51.97%   -0.46%     
===========================================
  Files          151      151              
  Lines        12346    12862     +516     
===========================================
+ Hits          6473     6685     +212     
- Misses        5873     6177     +304     
Impacted Files Coverage Δ
src/Settings.h 50.00% <ø> (ø)
src/Settings.cpp 100.00% <100.00%> (ø)
tests/Settings.cpp 100.00% <100.00%> (ø)
tests/Point.cpp 100.00% <0.00%> (ø)
src/effects/Tracker.cpp 0.00% <0.00%> (ø)
src/CVObjectDetection.cpp 0.00% <0.00%> (ø)
src/ClipProcessingJobs.cpp 0.00% <0.00%> (ø)
src/effects/Stabilizer.cpp 0.00% <0.00%> (ø)
src/effects/ObjectDetection.cpp 0.00% <0.00%> (ø)
src/CVStabilization.cpp 89.51% <0.00%> (+1.33%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a00bbb7...97c2530. Read the comment docs.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented May 15, 2021

I also added a unit test for the feature (which involved working out how to have CTest configure the environment for certain unit tests), and added a VERBOSE_TESTS option to the CMake configuration. It defaults OFF, but if enabled on the command line will run ctest with the -VV argument, causing it to output detailed setup/execution information as each test is run. (It also shows the stdout/stderr of the tests themselves, which is normally suppressed.)

@ferdnyc
Copy link
Contributor Author

ferdnyc commented May 15, 2021

With testing in place, I'm going to merge this. It's handy to have, and shouldn't affect anything else unless it's used.

@ferdnyc ferdnyc merged commit 42f9aee into OpenShot:develop May 15, 2021
@ferdnyc ferdnyc deleted the debug-envvar branch May 15, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant