Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-abstract effects #683

Merged
merged 5 commits into from Jun 5, 2021
Merged

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Jun 5, 2021

There were some issues with recent changes that caused SWIG to lose the definitions of all of our effect classes, making them abstract in the Python bindings. This PR brings them back to reality, and fixes the unit-test failures occurring in OpenShot due to the lack of openshot.Mask() in the bindings.

@ferdnyc ferdnyc added code Source code cleanup, streamlining, or style tweaks bindings libopenshot's Python or Ruby interface bindings labels Jun 5, 2021
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Jun 5, 2021

I meant to courtesy-CC the primary author for this code — cc: @BrennoCaldato

@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

Merging #683 (fcfb633) into develop (6562824) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #683   +/-   ##
========================================
  Coverage    50.41%   50.41%           
========================================
  Files          155      155           
  Lines        13317    13315    -2     
========================================
- Hits          6714     6713    -1     
+ Misses        6603     6602    -1     
Impacted Files Coverage Δ
src/EffectBase.cpp 18.75% <0.00%> (-0.40%) ⬇️
src/EffectBase.h 50.00% <0.00%> (ø)
src/TrackedObjectBBox.h 25.71% <ø> (ø)
src/TrackedObjectBBox.cpp 66.18% <62.50%> (-0.25%) ⬇️
src/TrackedObjectBase.cpp 33.33% <75.00%> (+8.33%) ⬆️
src/TrackedObjectBase.h 50.00% <100.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6562824...fcfb633. Read the comment docs.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Jun 5, 2021

Merging to fix our OpenShot CI runs.

@ferdnyc ferdnyc merged commit 5cca6d1 into OpenShot:develop Jun 5, 2021
@ferdnyc ferdnyc deleted the non-abstract-effects branch June 5, 2021 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindings libopenshot's Python or Ruby interface bindings code Source code cleanup, streamlining, or style tweaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant