CMake: USE_SWIG_DEPENDENCIES for CMake 3.20+ #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdnyc
added
build
Codecov Report
@@ Coverage Diff @@
## develop #691 +/- ##
========================================
Coverage 50.41% 50.41%
========================================
Files 155 155
Lines 13315 13315
========================================
Hits 6713 6713
Misses 6602 6602 Continue to review full report at Codecov.
|
|
Merging, as this is a Good Thing™ for the very few developers it will currently affect (CMake 3.20 being quite new, at the moment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(F---ING FINALLY!!!)
Mostly a developer convenience, when building using the newest CMake 3.20 or later, the SWIG targets will be configured with
USE_SWIG_DEPENDENCIESset toTRUE, which causes the target to automatically set up dependencies on all of the files referenced by the SWIG bindings.Which means, when you make changes to
Frame.horClip.hor whatever, the bindings will be automatically regenerated, and you no longer have torm -r build/bindingsin order to force a re-sync with the header files.