Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid starting PTS value (blank 1st frame) #695

Merged
merged 7 commits into from
Jul 3, 2021
Merged

Fix invalid starting PTS value (blank 1st frame) #695

merged 7 commits into from
Jul 3, 2021

Commits on Jun 25, 2021

  1. Fix invalid starting PTS value, preventing blank 1st frames on some t… 

    …humbnailing and video players.
    @jonoomph
    jonoomph committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    bdf6e9f View commit details
    Browse the repository at this point in the history

  2. Reduced, but didn't eliminate empty time at the beginning

    @JacksonRG
    JacksonRG committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    64e5782 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2021

  1. We already init values in constructor, and moving incrementing to lat… 

    …er in function.
    @jonoomph
    jonoomph committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    1cec184 View commit details
    Browse the repository at this point in the history

  2. Experimental conversion of timestamp rescaling to use the av_packet_r… 

    …escale_ts() method. I'm just not sure the backwards compatibility of this approach with older FFmpeg versions.
    @jonoomph
    jonoomph committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    5b524ab View commit details
    Browse the repository at this point in the history

  3. Switch to pkt.duration for incrementing PTS, and rename the 2 timesta… 

    …mp variables to something more sane.
    @jonoomph
    jonoomph committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    850140d View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2021

  1. Unit tests: --output-on-failure

    @ferdnyc
    ferdnyc committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    0f2f2e1 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2021

  1. Reverting video_timestamp increment logic which used pkt.duration. In… 

    … some codecs (such as vp8), this approach breaks due to differences in the timebase vs the framerate. For example, if the timebase is an inverse of the FPS, everything works. But if the timebase is not, for example 1/1000000, this approach breaks.
    @jonoomph
    jonoomph committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    9ca63b3 View commit details
    Browse the repository at this point in the history