Fix audio encoding on FFmpeg 4+ #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s that need to be set in newer versions of FFmpeg. This is also compatible with FFmpeg 3+.
Codecov Report
@@ Coverage Diff @@
## develop #698 +/- ##
===========================================
+ Coverage 50.40% 50.41% +0.01%
===========================================
Files 155 155
Lines 13291 13294 +3
===========================================
+ Hits 6699 6702 +3
Misses 6592 6592
Continue to review full report at Codecov.
|
JacksonRG
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVFrame was missing a few properties that need to be set in newer versions of FFmpeg. This is also compatible with FFmpeg 3+, based on my testing.
Closes: #676