Fix Frame::GetSamplesPerFrame when channels = 0 #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is relying on the implementation defined behavior of x86_64 to work properly. On x86_64, `fmod` returns -NaN when `channels = 0`, it is handled by `if (samples_per_frame < 0)`. But on other architectures(like riscv64), `fmod` may return a positive NaN which will cause this function to return a bad value. It is causing several tests to spin forever on riscv64. This PR fixes it by directly return 0 when `channels == 0` so that we do not need to deal with NaNs.
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
May 30, 2023
Patch upstreamed: - OpenShot/libopenshot#930 - OpenShot/libopenshot#929
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
May 31, 2023
Patch upstreamed: - OpenShot/libopenshot#930 - OpenShot/libopenshot#929
|
Thanks! LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is relying on the implementation defined behavior of x86_64 to work properly.
On x86_64,
fmodreturns -NaN whenchannels = 0, it is handled byif (samples_per_frame < 0).But on other architectures(like riscv64),
fmodmay return a positive NaN which will cause this function to return a bad value.It is causing several tests to spin forever on riscv64.
This PR fixes it by directly return 0 when
channels == 0so that we do not need to deal with NaNs.