Fixes test file collisions with high concurrency builds #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ninpo
force-pushed
the
fix-test-file-collisions
branch
from
a6f9f73
to
711e3e4
Compare
Fix by Ninpo <ninpo@qap.la> When tests are run in parallel it's possible for ImageWriter and FFmpegWriter Gif tests to truncate/overwrite the other's output1.gif. This change makes use of test file names unique to the tests themselves. Because cmake defaults to Makefiles and make does not -j$(nproc) by default, this bug can't show up unless part of a build with parallel make with tests included. OpenShot#933
Ninpo
force-pushed
the
fix-test-file-collisions
branch
from
711e3e4
to
e17c2a3
Compare
|
@Ninpo Thanks and sorry for the delays! Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix by Ninpo ninpo@qap.la
#933