Improved Tracker & Object Detector Effects (Faster Drawing, Corner Radius, New Style) #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Draw Tracker boxes using QPainter and support corner radius (and faster drawing performance by drawing directly on the frame) - Draw child clips with correct aspect ratio - Adding "Yes/No" options for "Visible" and "Draw Box" Tracked Object Box keyframes - default to invisible background - default to 12 corner radius - default to 50% stroke alpha
- Draw bounding boxes using QPainter and support corner radius (and faster drawing performance by drawing directly on the frame) - Draw child clips with correct aspect ratio - Adding "Yes/No" option for "Draw Text" - default to fully opaque stroke
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #950 +/- ##
===========================================
+ Coverage 53.93% 54.26% +0.32%
===========================================
Files 182 182
Lines 16649 16505 -144
===========================================
- Hits 8980 8956 -24
+ Misses 7669 7549 -120 ☔ View full report in Codecov by Sentry. |
…evious layers, replace std::shared_ptr<openshot::Frame> with QSize for a few arguments to make it much more clear what is happening.
…a circle in my testing). Also, ignoring case of class_filter on Object Detection effect.
…d of the confidence score. This is way more useful, so you can find the object in the properties menu. Also, output the visible class names as well, so the property editor can display them in a context menu.
…o tracker or object detection effects: Use clip->Parent to attach clips to tracked objects now.
…ent clip can be scaled and moved without breaking the tracking. Also refactoring out unneeded complex code left over.
… late-bound check, to ensure we have attached the clip on first call.
…n is of varying aspect ratios (since the parent clip and tracked object can change over time). Clips which are parented to tracked objects now respect the scale_type (i.e. best fit, stretch, etc...).
… difficult to turn off each individual box. Made "visible" property read-only on Tracker & Object Detector effects. Improve Keyframe::SetJsonValue method to accept an object or a float.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this PR: OpenShot/openshot-qt#5430
Improvements:
Added "Parent" badge to any clip with a parent set (on timeline for clarity)
Fixed
class_filterin property window to allow for:Background Corner Radius: allow up to 150
Updated Object Detector to output "class_name: object id" as the format (instead of confidence decimal) - easier to identify and select object in properties.
Removed "Child Clip ID" from Tracker and Object Detector Effect. "Parent" is now the only supported method of attaching clips to tracked objects.
Made certain properties read-only (X1, X2, Y1, Y2, etc...)
Fixed invalid background_alpha and stroke_alpha properties (reversed range... it was backwards)
Added new Display All Boxes property, which affects all Object Detector tracked boxes with a single property
Lots of refactoring and simplifying (i've removed 2 times as much code as I've added in this PR)
Refactored clip caching:
Refactor Object Detector with QPainter (support for corner radius, faster drawing performance)
Refactor Tracker with QPainter (support for corner radius, faster drawing performance)
