Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install icons to hicolor/NxN instead of hicolor/N #2837

Merged
merged 1 commit into from Jun 29, 2019
Merged

Install icons to hicolor/NxN instead of hicolor/N #2837

merged 1 commit into from Jun 29, 2019

Conversation

Bluewind
Copy link
Contributor

Nearly all other Arch Linux packages also follow this pattern and the Freedesktop specification also only uses this pattern when providing examples.

References:
https://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
https://bugs.archlinux.org/task/62900

Note: I didn't verify how this behaves in GUI file managers/GUI application launchers since I do not use any of them. I created this patch just based on the bug report and the icon theme spec.

Nearly all other Arch Linux packages also follow this pattern and the Freedesktop specification also only uses this pattern when providing examples.

References:
https://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
https://bugs.archlinux.org/task/62900
@ferdnyc
Copy link
Contributor

ferdnyc commented Jun 29, 2019

Huh. I never noticed that! While both paths are supported on Fedora, OpenShot is literally the only app on my system using /usr/share/icons/hicolor/{64,256,512}/apps/. Everything else is in the NxN paths. Thanks!

@ferdnyc ferdnyc merged commit 7ff9b84 into OpenShot:develop Jun 29, 2019
@Bluewind Bluewind deleted the patch-1 branch June 30, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants