Improved Captions + File Properties Improvements #5143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. alpha, scale, location, rotation, etc...)
…ject profile size (in cases of waveform generation)
…f a new Clip object reader.
…g - to prevent stretching the image of certain clips. This was stretching images when exporting a horizontal project to a vertical profile.
…plit clips) - Large refactor to File Properties dialog (update related clips after changing file path or FPS, update form after switching files, scale start/end when changing FPS, group transactions for undo/redo, update thumbnails for all related clips and file) - Adding Clips refactored to re-use File object data (instead of a fresh Clip Reader) - faster and more sane. Refactor thumbnail updating. Also, respect 'start' and 'end' properties of File object.
jonoomph
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to libopenshot PR: OpenShot/libopenshot#899
Add to TimelineorDrag n Drop) - to re-use existing File object, including any customizedstart,end, orFPSchanges.File Propertiesdialog, to correctly replace a File (browse button) or a FPS change to an image sequence - and replace the file details on all related clips (including a transaction for undo/redo as a single click). This also fixes a bug with the related clips not generating new thumbnails.