Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of mod updates #102

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

paoloambrosio
Copy link
Contributor

@paoloambrosio paoloambrosio commented Nov 13, 2023

Closes #92.

  • Use file hash to detect updates
    • Store installed hash
      • After installation
      • From modification timestamp and size
      • Optional for backward- (not present) and forward- (different name) compatibility
    • Read but not store available hash
  • Show out of date mods in the UI
    • Add out of date icon
    • Use out-of-date information from mod hash (available vs installed)

Out of scope for this:

  • Two-level hash with hash of modification timestamp and size of files (consider file order) Store content hash (from modification timestamp and size of files) for both available and installed mod
    • File hash only for available to know if the content hash has changed since last checked
    • Only for installed mods
    • Store after installation and if changed on fetch
  • Versioned (split hasher and hash algorithm with name) (no need for this as the hash would change if different and we would consider it changed even between different hash versions)

@paoloambrosio paoloambrosio marked this pull request as ready for review February 22, 2024 17:42
@paoloambrosio paoloambrosio merged commit 3229332 into OpenSimTools:main Feb 22, 2024
1 check passed
@paoloambrosio paoloambrosio deleted the 92-track-mod-updates branch February 22, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep track of mod updates
1 participant