Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tp/spec motion request #63

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature/tp/spec motion request #63

wants to merge 3 commits into from

Conversation

dbeckerAC
Copy link

Reference to a related issue in the repository

Related to PR Comment

Add a description

Add specification for MotionRequest top level message

Mention a member

@kmeids @max-rosin for review

Check the checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation for osi-sensor-model-packaging.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

see here:
https://github.com/OpenSimulationInterface/osi-sensor-model-packaging/runs/2296152415

@stefancyliax stefancyliax mentioned this pull request Sep 16, 2021
Merged
6 tasks
@pmai
Copy link
Contributor

pmai commented Jan 16, 2023

CCB 2023-01-16: PR should be updated to new documentation structure, more than one input/output should be allowed (using the general rules).

dbeckerAC
dbeckerAC commented Jan 30, 2023
View reviewed changes
doc/spec/motion_request_inputs.adoc Outdated Show resolved Hide resolved
doc/spec/motion_request_outputs.adoc Outdated Show resolved Hide resolved
@dbeckerAC
Use new documentation structure
155cde9 
Signed-off-by: Daniel Becker <danielb.ac@me.com>
dbeckerAC and others added 2 commits January 30, 2023 09:38
@dbeckerAC
Merge branch 'master' into feature/tp/SpecMotionRequest
0e6d391
@dbeckerAC
use new name for request type
174b644 
Signed-off-by: Daniel Becker <daniel.becker4@rwth-aachen.de>
@dbeckerAC
Copy link
Author

CCB 2023-01-16: PR should be updated to new documentation structure, more than one input/output should be allowed (using the general rules).

Done.

Also, I did not see any "must" requirements in other specifications anymore. Do we still use them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kmeids kmeids

@max-rosin max-rosin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dbeckerAC @pmai @kmeids @max-rosin