Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace libraries that use ViewEngine #2345

Closed
bastianjoel opened this issue May 30, 2023 · 3 comments · Fixed by #2810
Closed

Replace libraries that use ViewEngine #2345

bastianjoel opened this issue May 30, 2023 · 3 comments · Fixed by #2810
Assignees
Milestone

Comments

@bastianjoel
Copy link
Member

bastianjoel commented May 30, 2023

ViewEngine libraries are deprecated with angular 16. To make an update easier we should update or replace libraries that currently use it.

The following libraries are affected:

Timepicker replacement:

Extract marker:
This library is so small that we should just implement its functionality ourselves in a helper function.

@bastianjoel bastianjoel added this to the 4.1 milestone May 30, 2023
@MSoeb MSoeb modified the milestones: 4.1, 4.2 Jun 30, 2023
@bastianjoel
Copy link
Member Author

There is a new fork of ngx-translate-extract which seems to be maintained here.

I would suggest merging our changes from https://github.com/OpenSlides/ngx-translate-extract to that fork and switching the dependency source.

@jsangmeister
Copy link
Contributor

Sure, sounds good. Although we will have to rebase our changes everytime the base changes. We could try to create a PR to the fork and see if the changes are useful for other users as well, but IIRC at least some if it was relatively specific to our code.

@bastianjoel
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants