Several fixes #21
Merged
Several fixes #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ranslation method calls
|
Hi, thanks for this excellent contribution! For the purposes of the changelog, would you be able to list out the significant fixes? From looking at the commits alone I'm not sure I can interpret everything correctly. |
|
The significant fixes were:
|
|
Thank you. Just published v8.2.3 with your fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr contains changes from https://github.com/OpenSlides/ngx-translate-extract to the original library and is rebased to this fork.
Several fixes and updated tests are included.
This fixes #12 and adds support to extract from subclasses without declaration.