Hide votedIDs (#125)

Hide voted_id from ongoing polls
OpenSlides · Mar 4, 2021 · b778a16 · b778a16
1 parent fcbcfb8
commit b778a16
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 26 deletions.
diff --git a/internal/apps/poll/restrict.go b/internal/apps/poll/restrict.go
@@ -7,8 +7,11 @@ import (
 	"github.com/OpenSlides/openslides3-autoupdate-service/internal/restricter"
 )
 
-// StatePublished is the state of a poll, when it is published.
-const StatePublished = 4
+// StateFinished and StatePublished are state ids of polls.
+const (
+	StateFinished  = 3
+	StatePublished = 4
+)
 
 // RestrictPoll restricts an element for an assignment or motion poll.
 func RestrictPoll(r restricter.HasPermer, canSee, canManage string, restrictedFiels []string) restricter.ElementFunc {
@@ -69,6 +72,10 @@ func RestrictPoll(r restricter.HasPermer, canSee, canManage string, restrictedFi
 			return nil, fmt.Errorf("unmarshal poll state: %w", err)
 		}
 
+		if state != StatePublished && state != StateFinished {
+			delete(poll, "voted_id")
+		}
+
 		// Delete some fields for no managers and unpublished polls.
 		if !(r.HasPerm(uid, canManage) || state == StatePublished) {
 			delete(poll, "votesvalid")

diff --git a/internal/test/export.json b/internal/test/export.json
@@ -16594,9 +16594,6 @@
           "id": 1,
           "onehundred_percent_base": "valid",
           "majority_method": "simple",
-          "voted_id": [
-            4
-          ],
           "user_has_voted": false,
           "user_has_voted_for_delegations": []
         },
@@ -16628,9 +16625,6 @@
           "id": 3,
           "onehundred_percent_base": "valid",
           "majority_method": "simple",
-          "voted_id": [
-            11
-          ],
           "user_has_voted": false,
           "user_has_voted_for_delegations": []
         },
@@ -46831,9 +46825,6 @@
           "id": 1,
           "onehundred_percent_base": "valid",
           "majority_method": "simple",
-          "voted_id": [
-            4
-          ],
           "user_has_voted": false,
           "user_has_voted_for_delegations": []
         },
@@ -46865,9 +46856,6 @@
           "id": 3,
           "onehundred_percent_base": "valid",
           "majority_method": "simple",
-          "voted_id": [
-            11
-          ],
           "user_has_voted": false,
           "user_has_voted_for_delegations": []
         },

diff --git a/internal/test/export.json.go b/internal/test/export.json.go