Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primitiveUtcWithOffset broken #488

Closed
marceltaeumel opened this issue Apr 22, 2020 · 3 comments
Closed

primitiveUtcWithOffset broken #488

marceltaeumel opened this issue Apr 22, 2020 · 3 comments
Labels

Comments

@marceltaeumel
Copy link
Contributor

VM 202004210425 (cog.spur 32-bit and 64-bit)
OS Windows 10 (Version 1909 Build 18363.778)

Today is -- obviously -- January 19 in the wonderful year of 586155. 😄

The primitive used in Time class >> #primPosixMicrosecondClockWithOffset: called primitiveUtcWithOffset returns strange information.

Works fine in VM 202003021730.

@nicolas-cellier-aka-nice
Copy link
Contributor

The first value returned by primPosixMicrosecondClockWithOffset looks like 0 - epochDelta \\ (1<<64) where epochDelta is the microseconds between Squeak epoch (1901) and unix epoch (1970).

IOW, it's like if ioUTCMicroseconds() is returning 0 or near 0...

@nicolas-cellier-aka-nice
Copy link
Contributor

Hmm, I might be guilty:

9d52fef

gonna check C precedence of operators...

@nicolas-cellier-aka-nice
Copy link
Contributor

bah, it's obviously 0, if only I used bitOr instead of bitAnd, it could have worked... Sorry

nicolas-cellier-aka-nice added a commit that referenced this issue Apr 24, 2020
I broke it in 9d52fef
While at it, fix the 4 copies of the function (without an IDE, I lost quite some time inspecting the wrong one!).
hogoww referenced this issue in hogoww/opensmalltalk-vm Dec 23, 2021
hogoww referenced this issue in hogoww/opensmalltalk-vm Dec 23, 2021
…true ] on method [ is:onObjStack: ] SURVIVED 8/8 test cases.
hogoww referenced this issue in hogoww/opensmalltalk-vm Feb 26, 2022
hogoww referenced this issue in hogoww/opensmalltalk-vm Feb 26, 2022
…itsOf: ] 9/41 Test Cases are NOT EQUIVALENT
guillep added a commit to tesonep/opensmalltalk-vm that referenced this issue May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants