Add sndio sound support for OpenBSD #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krono
reviewed
Dec 9, 2019
| @@ -11,7 +11,7 @@ LDFLAGS="" | |||
| case $(uname -s) in | |||
| OpenBSD) | |||
| CFLAGS="$CFLAGS -I/usr/local/include" | |||
| LIBS="$LIBS -lexecinfo" | |||
| LIBS="$LIBS -lexecinfo -lsndio" | |||
There was a problem hiding this comment.
This should go in Makefile.inc in the plugins dir as such:
PLIBS=-lsndio
| @@ -0,0 +1,201 @@ | |||
| /* sqUnixSndioSound.c -- sound module for sndio sound system | |||
| * | |||
| * Last edited: 2005-04-06 05:44:40 by piumarta on pauillac.hpl.hp.com | |||
| #include <stdio.h> | ||
| #include <sndio.h> | ||
|
|
||
| #define trace() fprintf(stderr, "%s:%d %s\n", __FILE__, __LINE__, __FUNCTION__) |
This commit introduces a new plugin "vm-sound-sndio" which uses the native OpenBSD sound system as backend. This commit is meant as an initial introduction of the plugin, as sound output currently blocks the whole VM. The plugin is not loaded by default and should only get built when running on OpenBSD.
|
Many thanks for your feedback and sorry for the late reply. I have updated the branch incorporating your suggestions. If you can find the time to have a loot at it again, I'd appreciate it. |
|
Looks good to me. Anyone else having a look? |
|
On Wed, Dec 11, 2019 at 1:56 PM Tobias Pape ***@***.***> wrote:
Looks good to me. Anyone else having a look?
I don't see anything problematic. Integrate?
… —
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#451?email_source=notifications&email_token=AIJPEW23V5BJRL3YZK6CWXLQYFOXNA5CNFSM4JYGZGYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGUWUKQ#issuecomment-564750890>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJPEWZRBHOIIHUR6OE3FDDQYFOXNANCNFSM4JYGZGYA>
.
--
_,,,^..^,,,_
best, Eliot
|
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Dec 23, 2021
…: ] on method [ lastPointerOfWhileSwizzling: ]
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Dec 23, 2021
… ] on method [ lastPointerOfWhileSwizzling: ] KILLED by 1/209 test cases.
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Dec 29, 2021
…lse] ] on method [ freeTreeNodesDo: ]
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Dec 29, 2021
…se] ] on method [ freeTreeNodesDo: ] KILLED by 1/234 test cases.
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Feb 26, 2022
… true ] on method [ popObjStack: ] 14 test cases.
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Feb 26, 2022
…true ] on method [ popObjStack: ] 10/14 Test Cases are NOT EQUIVALENT
tesonep
added a commit
to tesonep/opensmalltalk-vm
that referenced
this pull request
Nov 28, 2022
…-windows Adding Libgit2-1.4.4 in Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new plugin "vm-sound-sndio" which uses the
native OpenBSD sound system as backend.
This commit is meant as an initial introduction of the plugin, as
sound output currently blocks the whole VM.
The plugin is not loaded by default and should only get built when
running on OpenBSD.
My intention with this pull request is to get the infrastructure for future improvements up and running, so further development is easier for me and people have a way of testing the plugin.