Fix issue #472

[nicolas-cellier-aka-nice]

when i == j, there is nothing to sort.
If we call this for the first time, there is no stack allocated by INIT(0), but stack is accessed nonetheless thru PUSH(i,j).
The best thing todo IMO is to return early.

[eliotmiranda]

Hi Nicolas, we trust you and with git's merge capability conflicts are unlikely. So why not do this on the main branch? I'm curious why you're doing this work on a branch...

…

On Tue, Jan 21, 2020 at 9:42 AM Nicolas Cellier ***@***.***> wrote: when i == j, there is nothing to sort. If we call this for the first time, there is no stack allocated by INIT(0), but stack is accessed nonetheless thru PUSH(i,j). The best thing todo IMO is to return early. ------------------------------ You can view, comment on, or merge this pull request online at: #473 Commit Summary - Fix issue #472 File Changes - *M* platforms/Cross/plugins/Squeak3D/b3dInit.c <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/473/files#diff-0> (6) Patch Links: - https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/473.patch - https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/473.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#473?email_source=notifications&email_token=ADY5VUCO6Q3K7YJ6NXWSUY3Q64XXXA5CNFSM4KJXN4FKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IHWSHIQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADY5VUDMGEOQGTCR2MOTKJ3Q64XXXANCNFSM4KJXN4FA> .

-- _,,,^..^,,,_ best, Eliot

[nicolas-cellier-aka-nice]

Hi Eliot,
This is a quick fix with superficial understanding of code.
So just to give a chance to review.

[fniephaus]

LGTM

[fniephaus]

I'm going to merge this as it avoids a crash. If someone doesn't agree with the fix, we can always revert it. But merging it now makes it easier for our users, and especially Stéphane, to try it out.