Use NSWindow API for changing fullscreen mode #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of going through NSView's API. The latter does offer more options, but messes up the fullscreen mode for some reason (UI becomes unresponsive because input events are no longer received). Using `self.window toggleFullScreen:self` also does not mess with additional displays (only the display showing Squeak is put into fullscreen mode).
| @@ -48,6 +48,7 @@ | |||
|
|
|||
| extern SqueakOSXAppDelegate *gDelegateApp; | |||
| extern struct VirtualMachine* interpreterProxy; | |||
| extern int getFullScreenFlag(); | |||
There was a problem hiding this comment.
Just a detail, but should be sqInt
There was a problem hiding this comment.
Have you given the PR a try locally?
eliotmiranda
approved these changes
Feb 28, 2020
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Dec 23, 2021
…[ is:onObjStack: ] SURVIVED 8/8 test cases.
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Feb 26, 2022
… [ scavengingGCTenuringIf: ] 14 test cases.
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Feb 26, 2022
…[ scavengingGCTenuringIf: ] 14/14 test case are EQUIVALENT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of going through NSView's API. The latter does offer more options, but messes up the fullscreen mode for some reason (UI becomes unresponsive because input events are no longer received).
Using
self.window toggleFullScreen:selfalso does not mess with additional displays (only the display showing Squeak is put into fullscreen mode).Please test and review!