Update VMMaker build scripts #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github now seems to lazy-load the list of downloadable files, so we can't get the download links from the HTML directly. It seems there is now a stable download URL available though, which we can just use directly.
I suspect the default nowadays is a 64-bit VM, so order this to the top. As a new user, I accidentally tried running the 32-bit Simulation, which ended up not working as I had only built the 64-bit Bochs plugin.
eliotmiranda
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix some errors in the VMMaker build scripts (at least for the 64-bit version) and improves the ergonomics of the Simulation workspace for newcomers by moving the 64-bit simulation to the top (assuming 64-bit simulation is the default nowadays).