Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toplo ready #14

Merged
merged 10 commits into from
Mar 8, 2024
Merged

Toplo ready #14

merged 10 commits into from
Mar 8, 2024

Conversation

Nyan11
Copy link
Collaborator

@Nyan11 Nyan11 commented Feb 1, 2024

No description provided.

@Nyan11 Nyan11 requested a review from labordep February 1, 2024 17:35
@Nyan11
Copy link
Collaborator Author

Nyan11 commented Feb 2, 2024

Do not merge until alpha5 on Pyramid

@labordep labordep added pending Waiting for something enhancement New feature or request labels Feb 2, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isLeaf -> shouldSerializeChildren

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nyan11 you can fix? I can do it no problem :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#16 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#16 ?

@labordep labordep removed the pending Waiting for something label Mar 8, 2024
@labordep labordep merged commit 92ce74c into main Mar 8, 2024
6 checks passed
@labordep labordep deleted the toplo branch March 8, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants