Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix should serialized #1

Merged
merged 2 commits into from
Mar 8, 2024
Merged

fix should serialized #1

merged 2 commits into from
Mar 8, 2024

Conversation

Nyan11
Copy link
Contributor

@Nyan11 Nyan11 commented Mar 8, 2024

Fix for Pyramid alpha5

@labordep labordep self-requested a review March 8, 2024 17:08
@labordep labordep added the bug Something isn't working label Mar 8, 2024
@@ -4,7 +4,7 @@ Extension { #name : #ToElement }
ToElement >> shouldSerializedChildren [
"Toplo elements should not serialize children by default. Manage exeptions in subclasses."

^ false
^ (self class == ToElement)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why class == ToElement? What it's happen for ToButton class for example? It is a ToElement but class ~= ToElement. It need to save children?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this is related to your comment below:

"Toplo-Serialization -> If we have a ToElement, it should serialized itt's children. If we have anything with TToPlaceHolder trait it should serialize it's children. Everithing else should not serialize it's children."

Ok so all subclasses of ToElement NOT serialize children.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in the examples of Toplo the ToElement is often used as a container. I consider a ToElement to be a container and all subclasses to be a "leaf"

@labordep labordep merged commit c6185c8 into main Mar 8, 2024
6 checks passed
@labordep labordep deleted the fix_should_serialize branch March 16, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants