Update README and pre-commit config

[timmens]

In this PR I added estimagics monthly download numbers as a badge to our README. I further went through our pre-commit hooks and looked for new ones. One new hook that stands out is refurbed. It proposes ways to replace code sections with more pythonic versions; however, it is not ready yet. It is too slow, sometimes proposes wrong things and ignoring arguments does not work well with pre-commit. My recommendation is to use the tool via the console once in a while and adopt some of the proposed changes but not integrate it into our pre-commit hook suite.

Changes

I recommend looking at the .pre-commit-config.yaml changes in split view. I deleted no hooks but added {pyupgrade, name-tests-test, check-toml, forbid-submodules}.

Tasks

• Add estimagic download numbers to README
• Close Use modern pre-commit hooks and implement own #413

[codecov]

Codecov Report

Merging #415 (3b897e2) into main (1e1883a) will increase coverage by 0.00%.
The diff coverage is 96.66%.

@@           Coverage Diff           @@
##             main     #415   +/-   ##
=======================================
  Coverage   92.88%   92.88%           
=======================================
  Files         223      222    -1     
  Lines       17450    17420   -30     
=======================================
- Hits        16208    16181   -27     
+ Misses       1242     1239    -3     

Impacted Files	Coverage Δ
src/estimagic/optimization/neldermead.py	90.62% <ø> (-0.10%)	⬇️
src/estimagic/parameters/process_selectors.py	91.12% <ø> (ø)
src/estimagic/optimization/pygmo_optimizers.py	92.66% <66.66%> (+1.44%)	⬆️
src/estimagic/visualization/estimation_table.py	84.93% <85.71%> (+0.25%)	⬆️
src/estimagic/optimization/__init__.py	100.00% <100.00%> (ø)
src/estimagic/optimization/convergence_report.py	100.00% <100.00%> (ø)
src/estimagic/optimization/nag_optimizers.py	89.47% <100.00%> (-0.27%)	⬇️
src/estimagic/optimization/optimize_result.py	95.94% <100.00%> (ø)
...stimagic/optimization/process_multistart_sample.py	53.33% <100.00%> (-2.92%)	⬇️
src/estimagic/optimization/process_results.py	96.15% <100.00%> (-0.28%)	⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[timmens]

@janosg

The new hook name-tests-test fails because

tests/visualization/helpers_test_estimation_table.py does not match pattern "test_.*\.py"

We can either rewrite (this would mean adding the three functions defined in helpers_test_estimation_table.py to the beginning of test_estimation_table.py) or ignore this case. I think I'd prefer a rewrite. What do you think?

[janosg]

Yes, I prefer the rewrite as well. Can you do it?

[janosg]

Thanks a lot!