Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align default containers with jax #14

Merged
merged 7 commits into from Feb 28, 2022
Merged

Align default containers with jax #14

merged 7 commits into from Feb 28, 2022

Conversation

janosg
Copy link
Member

@janosg janosg commented Feb 25, 2022

Currently we have only list, dict and tuple as default pytree containers.

Jax also has:

  • None
  • collections.namedtuple and typing.NamedTuple
  • collections.OrderedDict

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #14 (83db5e1) into main (7108cf7) will increase coverage by 1.76%.
The diff coverage is 96.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   93.54%   95.30%   +1.76%     
==========================================
  Files           7        9       +2     
  Lines         372      405      +33     
==========================================
+ Hits          348      386      +38     
+ Misses         24       19       -5     
Impacted Files Coverage Δ
src/pybaum/registry_entries.py 88.40% <88.88%> (+5.73%) ⬆️
src/pybaum/registry.py 100.00% <100.00%> (ø)
src/pybaum/tree_util.py 94.85% <100.00%> (+0.03%) ⬆️
src/pybaum/typecheck.py 100.00% <100.00%> (ø)
tests/test_tree_util.py 100.00% <100.00%> (ø)
tests/test_typecheck.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7108cf7...83db5e1. Read the comment docs.

Copy link
Member

@tobiasraabe tobiasraabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🎉

src/pybaum/registry.py Outdated Show resolved Hide resolved
@janosg janosg merged commit 1675270 into main Feb 28, 2022
@janosg janosg deleted the more-containers branch February 28, 2022 10:34
@tobiasraabe tobiasraabe added this to the v0.1.2 milestone Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants