Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring thank you text in the center #156

Closed
wants to merge 2 commits into from
Closed

Bring thank you text in the center #156

wants to merge 2 commits into from

Conversation

kanishkarj
Copy link

@kanishkarj kanishkarj commented Oct 18, 2017

Checklist

  • My branch is up-to-date with the upstream develop branch.
  • I have added necessary documentation (if appropriate).

Which issue does this PR fix?: fixes #150
This PR brings the thank you text to the center and replaces Y with y.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.474% when pulling 203df8a on kanishkarj:predev into 2a0e5fd on OpenSourceHelpCommunity:predev.

@kanishkarj kanishkarj closed this Oct 18, 2017
@kanishkarj kanishkarj reopened this Oct 18, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.474% when pulling a91736f on kanishkarj:predev into 2a0e5fd on OpenSourceHelpCommunity:predev.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.474% when pulling a91736f on kanishkarj:predev into 2a0e5fd on OpenSourceHelpCommunity:predev.

@vaibhavsingh97
Copy link
Member

@kanishkarj Thanks for contributing!! 😄 As i am seeing that you are vary enthusiast to contribute in this project but as d3vil0p3r already fixed the issue so it's fair to give hime the chance and merge his PR 🚀 .

Hey!! This is not the end of open source development, you can look into existing issues and try to fix the issue. In case you stuck anywhere just message on the slack channel (Request you invite here). Anyone who are online will help you with the issues you are facing, alternatively you can search on google and stackoverflow. Maybe people had faced the same issue you faced and provided the solution.

Happy Coding!!

@@ -4,7 +4,7 @@

<div class="jumbotron text-xs-center">
<div class="container text-center">
<h1 class="display-3">Thank You!</h1>
<h1 class="display-3 text-center">Thank you!</h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't working for me on my local or trial deployment. I have cache disabled. Can you please share screenshots?

Copy link
Member

@tapaswenipathak tapaswenipathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@tapaswenipathak
Copy link
Member

tapaswenipathak commented Oct 21, 2017

Someone fixed this issue with 8c1d068, so closing this one. Feel free to pick any other open issues or raise new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring thank you text in the center
4 participants