Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueError at /add_contest/ #148 #157

Merged
merged 1 commit into from
Oct 20, 2017
Merged

ValueError at /add_contest/ #148 #157

merged 1 commit into from
Oct 20, 2017

Conversation

sparkle-sparkle
Copy link

  • make date input fields required
  • define date pattern matching the pattern in the placeholder

Checklist

  • My branch is up-to-date with the upstream develop branch.
  • I have added necessary documentation (if appropriate).

Which issue does this PR fix?: fixes #

Brief description of what this PR does.
Add issue number here. If you do not solve the issue entirely, please change the message e.g. "First steps for issues #IssueNumber"

Why do we need this PR?:

If relevant, please include a screenshot.

Demo (optional):

Some tips for you to write the instructions:

  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as migrating databases, etc.

Testing instructions:

If there is any work still left to do, please add it here.

TODOs (if any):

A picture of a cute animal (not mandatory but encouraged):

* make date input fields required
* define date pattern matching the pattern in the placeholder
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.474% when pulling 9564a05 on sparkle-sparkle:predev into 2a0e5fd on OpenSourceHelpCommunity:predev.

Copy link
Member

@vaibhavsingh97 vaibhavsingh97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing 😄 This PR is ready to ship 🚀
image
image

@sparkle-sparkle
Copy link
Author

Happy to help 😄

Copy link
Member

@tapaswenipathak tapaswenipathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

@tapaswenipathak tapaswenipathak merged commit 9ec80ff into OpenSourceHelpCommunity:predev Oct 20, 2017
@sparkle-sparkle
Copy link
Author

You're welcome

@anubhakushwaha anubhakushwaha mentioned this pull request Dec 9, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants