Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contest_submission.html #158

Closed

Conversation

thomas-booker
Copy link

@thomas-booker thomas-booker commented Oct 18, 2017

Centered "Thank you" and "Your contest...", and changed "... You" to "... you".

Checklist

  • My branch is up-to-date with the upstream develop branch.
  • I have added necessary documentation (if appropriate).

Which issue does this PR fix?: fixes #150

Centered the two texts as requested, and also changed uppercase Y to lowercase.

Why do we need this PR?:

To change the text, as requested.

If relevant, please include a screenshot.

Demo (optional):

Some tips for you to write the instructions:

  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as migrating databases, etc.

Testing instructions:

If there is any work still left to do, please add it here.

TODOs (if any):

A picture of a cute animal (not mandatory but encouraged):

Centered "Thank you" and "Your contest...", and changed "... You" to "... you".
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.474% when pulling 6d7e804 on thomas-booker:patch-1 into b709a40 on OpenSourceHelpCommunity:predev.

@vaibhavsingh97
Copy link
Member

@thomas-booker Thanks for contributing!! 😄 As i am seeing that you are vary enthusiast to contribute in this project but as d3vil0p3r already fixed the issue so it's fair to give hime the chance and merge his PR 🚀 .

Hey!! This is not the end of open source development, you can look into existing issues and try to fix the issue. In case you stuck anywhere just message on the slack channel (Request you invite here). Anyone who are online will help you with the issues you are facing, alternatively you can search on google and stackoverflow. Maybe people had faced the same issue you faced and provided the solution.

Happy Coding!!

<h1 class="display-3">Thank You!</h1>
<p class="lead"><strong>Your contest has been submitted for review.</strong></p>
<h1 class="display-3" style="text-align: center">Thank you!</h1>
<p class="lead" style="text-align: center"><strong>Your contest has been submitted for review.</strong></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't working for me, can you please share screenshots?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contest submission screenshot

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

center of the page, like vertically and horizontally in the center of the page. I will update the description.

@tapaswenipathak
Copy link
Member

Someone fixed this issue with 8c1d068, so closing this one. Feel free to pick any other open issues or raise new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring thank you text in the center
4 participants