Seperate settings for dev, predev and production. #200
Conversation
| from .base import * | ||
|
|
||
|
|
||
| DEBUG = os.getenv("DEBUG", False) |
There was a problem hiding this comment.
'os' may be undefined, or defined from star imports: .base
| @@ -0,0 +1,5 @@ | |||
| # production settings | |||
| from .base import * | |||
There was a problem hiding this comment.
'from .base import *' used; unable to detect undefined names
| from .base import * | ||
|
|
||
|
|
||
| DEBUG = os.getenv("DEBUG", True) |
There was a problem hiding this comment.
'os' may be undefined, or defined from star imports: .base
| @@ -0,0 +1,5 @@ | |||
| # predev settings | |||
| from .base import * | |||
There was a problem hiding this comment.
'from .base import *' used; unable to detect undefined names
| from .base import * | ||
|
|
||
|
|
||
| DEBUG = os.getenv("DEBUG", False) |
There was a problem hiding this comment.
'os' may be undefined, or defined from star imports: .base
| @@ -0,0 +1,5 @@ | |||
| # dev settings | |||
| from .base import * | |||
There was a problem hiding this comment.
'from .base import *' used; unable to detect undefined names
| @@ -16,6 +16,7 @@ install: | |||
| - pip install coveralls | |||
|
|
|||
| before_script: | |||
| - export SECRET_KEY='x1-pogt0-b5owbgq0=ui02-4v)bba!bg&1m8_$)8-&13(907qf' | |||
There was a problem hiding this comment.
Did you test this by enabling Travis for your fork?
There was a problem hiding this comment.
Thanks for picking this one again! 🎉
It is super easy to remove hound errors appearing in your pr, just follow what the fix is saying, linking a useful read.
Checklist
developbranch.Which issue does this PR fix?: fixes #
Brief description of what this PR does.
#164. Separate settings for dev, predev and production. Also removes 'SECRET_KEY' value from the settings file.
Why do we need this PR?:
To address issue #164.
If relevant, please include a screenshot.
Demo (optional):
Some tips for you to write the instructions:
Testing instructions:
python manage.py runserver. If your environment variable is set correctly, website will launch properly. If not, you will get 'ImproperlyConfigured("The SECRET_KEY setting must not be empty.")' error message.If there is any work still left to do, please add it here.
TODOs (if any):
A picture of a cute animal (not mandatory but encouraged):
