Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use env variables to set SMTP settings #222

Merged

Conversation

jarifibrahim
Copy link
Member

@jarifibrahim jarifibrahim commented Jan 5, 2018

Fixes #204

Note - The application will return an Internal Server Error if any of these variables are not set.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.269% when pulling 4c27cf1 on jarifibrahim:env-variable into 3741eed on OpenSourceHelpCommunity:predev.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.269% when pulling 3f4cd11 on jarifibrahim:env-variable into 3741eed on OpenSourceHelpCommunity:predev.

@jarifibrahim
Copy link
Member Author

Closing this PR since we do not need email related features at the moment.

#224 makes this PR obsolete

EMAIL_USE_TLS = True

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Register/Login is of no good use if we don't confirm the email. Currently we have it hidden on master, once we are up with check we would make it live. This is needed and cannot be removed. Did you get the chance to set it on Heroku? or does this not work for you? looks good.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tapasweni-pathak There is a known issue with Gmail and Heroku. Heroku servers are located all around the world. When we try to send an email via Heroku server, Gmail blocks the request considering the unusual origin of the request. We could try and see if this works, but I'm not sure if this email verification via emails from gmail should be used on production.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happens with mutt too if you use it with Gmail, this needs to be set up in that case and we can restrict to heroku. Can you please drop a blog or something, as I'm aware about this but not about the known issue, thanks!

@jarifibrahim
Copy link
Member Author

@tapasweni-pathak Let's merge this and see if it works. We'll never know until we try ;)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.269% when pulling 3f4cd11 on jarifibrahim:env-variable into 3741eed on OpenSourceHelpCommunity:predev.

@tapaswenipathak tapaswenipathak merged commit 778ac2b into OpenSourceHelpCommunity:predev Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants