Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cannot change initiative type #523

Merged
merged 4 commits into from
May 20, 2024

Conversation

Stef-Rousset
Copy link
Contributor

🎩 Description

As an admin, I cannot change the type of an initiative sent in technical validation for a type with global scope.

📌 Related Issues

Testing

Describe the best way to test or validate your PR.

  1. Go to /admin/initiatives
  2. Click on the initiative configuration button of an initiative sent in technical validation
  3. Modify the "Type" field for a type wtih global scope
  4. Update the changes
  5. See that the new initiative type is applied

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.73%. Comparing base (49a84c5) to head (a5b788a).
Report is 8 commits behind head on develop.

Current head a5b788a differs from pull request most recent head f432e2c

Please upload reports for the commit f432e2c to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #523       +/-   ##
============================================
+ Coverage    45.12%   77.73%   +32.60%     
============================================
  Files           46       58       +12     
  Lines         1026     1334      +308     
============================================
+ Hits           463     1037      +574     
+ Misses         563      297      -266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Quentinchampenois
Copy link
Contributor

Ready for review, CodeCov is blocking CI completion because of code coverage upload

@Quentinchampenois Quentinchampenois marked this pull request as ready for review April 30, 2024 08:39
@luciegrau luciegrau linked an issue Apr 30, 2024 that may be closed by this pull request
Copy link
Contributor

@BarbaraOliveira13 BarbaraOliveira13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in local 💯

Copy link
Contributor

@Quentinchampenois Quentinchampenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CI is failing because of CodeCov upload, will be fixed in another PR

luciegrau
luciegrau previously approved these changes May 2, 2024
Copy link
Collaborator

@luciegrau luciegrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thank you!
⚠️ DO NOT merge please, we are waiting for the v2.1.0 to be released!

@Quentinchampenois Quentinchampenois merged commit fb6fa6d into develop May 20, 2024
14 checks passed
@Quentinchampenois Quentinchampenois deleted the fix/cannot_change_initiative_type branch May 20, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot change initiative type as an admin
4 participants