-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/cannot change initiative type #523
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #523 +/- ##
============================================
+ Coverage 45.12% 77.73% +32.60%
============================================
Files 46 58 +12
Lines 1026 1334 +308
============================================
+ Hits 463 1037 +574
+ Misses 563 297 -266 ☔ View full report in Codecov by Sentry. |
Ready for review, CodeCov is blocking CI completion because of code coverage upload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested in local 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI is failing because of CodeCov upload, will be fixed in another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thank you!
f432e2c
🎩 Description
As an admin, I cannot change the type of an initiative sent in technical validation for a type with global scope.
📌 Related Issues
Testing
Describe the best way to test or validate your PR.