Fix mistake in preview + refactor test

OpenSourcePolitics · Nov 8, 2018 · b845f3c · b845f3c
1 parent a571342
commit b845f3c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/decidim-proposals/app/views/decidim/proposals/proposals/preview.html.erb b/decidim-proposals/app/views/decidim/proposals/proposals/preview.html.erb
@@ -42,8 +42,6 @@
             </div>
           <% end %>
         <% end %>
-      <div class="card__content">
-        <%= render partial: "proposal_preview", locals: {proposal: @proposal} %>
         <div class="row column flex-center">
           <%= link_to t(".modify"), edit_draft_proposal_path(@proposal) %>
 

diff --git a/decidim-proposals/spec/shared/proposals_wizards_examples.rb b/decidim-proposals/spec/shared/proposals_wizards_examples.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-shared_examples "proposals wizards" do |with_address|
+shared_examples "proposals wizards" do |options|
   include_context "with a component"
   let(:manifest_name) { "proposals" }
 
@@ -19,7 +19,7 @@
            participatory_space: participatory_process)
   end
 
-  if with_address
+  if options == :with_address
     let(:proposal_address) { "Carrer Pare Llaurador 113, baixos, 08224 Terrassa" }
     let(:latitude) { 40.1234 }
     let(:longitude) { 2.1234 }
@@ -152,7 +152,7 @@
         Decidim::EngineRouter.main_proxy(component).proposal_path(proposal_draft) + "/preview"
       end
 
-      if with_address
+      if options == :with_address
         let!(:proposal_draft) do
           create(:proposal, :draft, author: user, component: component, title: proposal_title, body: proposal_body, address: proposal_address)
         end
@@ -172,7 +172,7 @@
 
       it "shows a preview" do
         expect(page).to have_css(".card.card--proposal", count: 1)
-        if with_address
+        if options == :with_address
           expect(page).to have_content("Your address has not been geocoded, preview is unavailable.")
           expect(page).to have_content("Address : #{proposal_address}")
         end

diff --git a/decidim-proposals/spec/system/proposal_wizard_spec.rb b/decidim-proposals/spec/system/proposal_wizard_spec.rb
@@ -4,5 +4,5 @@
 
 describe "Proposal", type: :system do
   it_behaves_like "proposals wizards"
-  it_behaves_like "proposals wizards", true
+  it_behaves_like "proposals wizards", :with_address
 end