Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erratic step CTA behavior #488

Closed
lu-hamani opened this issue Feb 12, 2019 · 1 comment
Closed

Erratic step CTA behavior #488

lu-hamani opened this issue Feb 12, 2019 · 1 comment
Assignees
@armandfardeau @lu-hamani
Labels
0.16-stable Version Non-blocking bug alternative solution exists URGENT To be dealt with immediately
Milestone
0.16-stable-debug II

Comments

@lu-hamani
Copy link

Describe the bug
Step CTA should redirect to the url specified in BO.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://in.opensourcepolitics.eu/processes
  2. Click on Step CTAs
  3. See error

Expected behavior
All CTA should redirect to the url set in BO.

Screenshots
screenshot 2019-02-12 at 15 26 00

Additional context
There might be some conflicts because of similar developments engaged by OSP and Barcelona.
@lu-hamani lu-hamani added Non-blocking bug alternative solution exists 0.16-stable Version NORMAL priority level labels Feb 12, 2019
@lu-hamani lu-hamani added this to the 0.16-stable-debug II milestone Feb 12, 2019
@lu-hamani lu-hamani added triage issues not qualified URGENT To be dealt with immediately and removed NORMAL priority level triage issues not qualified labels Feb 26, 2019
moustachu added a commit that referenced this issue Mar 14, 2019
@moustachu
🐛 Merge fix for CTA path #488
4ce6f6c
@lu-hamani lu-hamani mentioned this issue Mar 14, 2019
Closed
13 tasks
@lu-hamani
Copy link
Author

lu-hamani commented Mar 14, 2019 •
edited

@moustachu
Fixes part of the problem unfortunately.

When on the process index the step cta in the process card is broken. See following screenshot :

  1. Screenshot 2019-03-14 at 17 46 07
  2. Screenshot 2019-03-14 at 17 46 14

The url in the second screenshot should be : https://dev.steamroll.osp.cat/processes/quasi-dolores/f/3/

moustachu added a commit that referenced this issue Mar 18, 2019
@moustachu
🐛 fix step_cta_path #488
cb8d77f
@moustachu moustachu mentioned this issue Mar 19, 2019
Merged
moustachu added a commit that referenced this issue Mar 19, 2019
@moustachu
Fix/0.16 w11 issues (#547)
debd8ff 
* [BACKPORT] Fix user presenter for user groups (decidim#4974)

* Fix user presenter for user groups (decidim#4973)

* Fix user presenter for user groups

The user groups do not have a `.deleted?` method defined for them
which caused the user presenter to break the notifications view
in case the notification was linking to a group user.

* Add CHANGELOG entry

* Fix changelog

* 🐛 ⏪ Better fixes for #525

- reverting 25bd9a4
- reverting 7b6f2e5
- better fix comes from decidim@7372946

* 🌐 amendable event FR label #532

* 🐛 HashtagRenderer in comment events #532

* 🐛 fix step_cta_path #488

* 🌐 [pages] FR "Titre" >> "Page" !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armandfardeau armandfardeau

@lu-hamani lu-hamani

Labels
0.16-stable Version Non-blocking bug alternative solution exists URGENT To be dealt with immediately
Projects
None yet
Milestone
0.16-stable-debug II
Development

No branches or pull requests
3 participants
@moustachu @armandfardeau @lu-hamani